Repository navigation
fix(gemma4): Restore KV sharing for the Gemma 4 assistants and their targets - #50531
Open
harshaljanjani wants to merge 1 commit into
Open
harshaljanjani wants to merge 1 commit into
harshaljanjani wants to merge 1 commit into
Conversation
Signed-off-by: Harshal Janjani <harshaljanjani@gmail.com>
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma4, gemma4_assistant, gemma4_unified, gemma4_unified_assistant |
qgallouedec
approved these changes
Nov 11, 2026
qgallouedec
left a comment
qgallouedec
left a comment
Member
There was a problem hiding this comment.
Thanks! LGTM, checked myself, cc @remi-or @Cyrilvallez for the merge.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
→ Fixes #50316
→ Assistants (all layers shared) now reuse every layer, and targets with
num_kv_shared_layers=0store the last layer of each type again as before #47290; a non-skipped tiny-configtest_assisted_decoding_matches_greedy_searchcovers both for Gemma 4 and Gemma 4 Unified.cc: @qgallouedec @remi-or @Cyrilvallez
Code Agent Policy
Before submitting